Migrate Quick Connect authorization workflow to Compose UI #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect_flow_migration
praveek
reviewed
Feb 6, 2024
|
|
||
| val assuranceStateManager: AssuranceStateManager = | ||
| AssuranceComponentRegistry.assuranceStateManager ?: run { | ||
| Log.e( |
praveek
reviewed
Feb 6, 2024
| internal class QuickConnectViewModel : ViewModel { | ||
| private val quickConnectManager: QuickConnectManager | ||
| private val environment: AssuranceConstants.AssuranceEnvironment | ||
| private val _state: MutableState<ConnectionState> |
There was a problem hiding this comment.
private val _state: MutableState<ConnectionState>
internal val state: State<ConnectionState>
get() = _state
praveek
approved these changes
Feb 6, 2024
|
The changes look good. Can you update the Makefile so that the CI passes? |
- Better way to set internal immutable state - Use MobileCore.Log instead of android.util.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the QuickConnect authorization workflow UI is based on XML based system. This PR migrates it to use Jetpack Compose UI for the 3.x version to enable better code flow and maintainability.
Key changes:
QuickConnectScreenthat is the entry point for the QuickConnect authorization phase. It hosts theQuickConnectViewcontaining all the UI elements associated with this screen for easier instrumentation tests.QuickConnectViewModelwhich is the bridge between the UI and the business logic (QuickConnectManager,SessionUIOperationHandler). This seamlessly fits into the workflow due to the changes done to quick connect UI being activity first unlike the 2.x pin screen.AssuranceActivitywhich already hosts thePinScreenandStatusScreenwill also host theQuickConnectScreen.AssuranceQuickConnectActitvityis no longer required and has been deleted. This makes Assurance a single activity flow withAssuranceNavHostas the single point of entry and control for the UI and business logic.AssuranceQuickConnectViewcomposes-
AssuranceHeaderandAssuranceSubHeader- QuickConnect graphic
-
QuickConnectErrorPanelwhich optionally displays the error during connection phase.-
ActionButtonRowthat contains a Cancel button and a multi-state Connect button.- The Connect button is using the custom
ProgressButtoncomposable that is managed byButtonStatethat defines its behavior and style (mapped to one ofIdle,Waiting,Retry)Related Issue
#88
How Has This Been Tested?
Note that the tests on this PR will fail due to compilation errors pending PinScreen test fixes. These will come as a fast follow
Screenshots (if appropriate):
Types of changes
Checklist: