Plumb Assurance StatusUi logs from AppState #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The status logs are limited to particular app launch. So store them as part of Assurance app state so that it can be updated from various UI. - Create a lazy list with the status ui logs and add them to the AssuranceStatusScreen. - Add tests
yangyansong-adbe
approved these changes
Feb 28, 2024
| */ | ||
| @JvmName("logStatus") | ||
| internal fun logStatus(level: AssuranceConstants.UILogColorVisibility, status: String) { | ||
| _statusLogs.value = _statusLogs.value + StatusLog(level, status) |
There was a problem hiding this comment.
nit: can we use _statusLogs.value += StatusLog(level, status)? It increases readability for me.
| private val _sessionPhase = mutableStateOf<SessionPhase>(SessionPhase.Disconnected()) | ||
|
|
||
| /** | ||
| * Represents the current phase of the assurance session. | ||
| */ | ||
| val sessionPhase: State<SessionPhase> = _sessionPhase | ||
|
|
||
| private val _statusLogs = mutableStateOf<List<StatusLog>>(emptyList()) |
There was a problem hiding this comment.
nit: can we consider using a more succinct expression -> private val _statusLogs = mutableStateOf(emptyList<StatusLog>())?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some components that add status logs (Assurance being connected, screenshot being captured etc) which can be displayed when the floating button is clicked. This PR adds support for such logging.
Motivation and Context
There are some components that add status logs (Assurance being connected, screenshot being captured etc) which can be displayed when the floating button is clicked. Add support for such logging.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: