Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HitQueuing+PrivacyStatus public #490

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Make HitQueuing+PrivacyStatus public #490

merged 1 commit into from
Jan 7, 2021

Conversation

emdobrin
Copy link
Contributor

@emdobrin emdobrin commented Jan 7, 2021

Description

Make HitQueuing+PrivacyStatus extension public to be used by other extensions outside of Core. To be used by Edge.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #490 (1b26062) into dev (5e60ecf) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #490   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          92       92           
  Lines        4099     4099           
=======================================
  Hits         3569     3569           
  Misses        530      530           

@nporter-adbe
Copy link
Contributor

This extension is currently under the Identity target; thus, it will only be available if you import Identity. I think it would be more ideal to move this to Core, so an extension that would like to use this utility extension doesn't need to explicitly depend/import Identity but rather core.

I considered that it might be a good fit under services, but we need the privacy status which is defined in core.

@emdobrin
Copy link
Contributor Author

emdobrin commented Jan 7, 2021

@nporter-adbe it is currently under configuration so I believe Core should bring that in already.

@nporter-adbe
Copy link
Contributor

@emdobrin ah my mistake... Looks like the actual class is in core but then the unit tests are still under identity. It was originally under Identity then moved to core. Must have missed moving the unit tests too.

@emdobrin emdobrin merged commit 70130e8 into dev Jan 7, 2021
@emdobrin emdobrin deleted the handlePrivacyChange branch January 7, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants