-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement batchLimit on PersistentHitQueue #496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev to main - fix date formatting, better debug logging
Dev to main
Dev to main, 3.0.0-beta.2
nporter-adbe
reviewed
Jan 8, 2021
AEPServices/Sources/utility/hitprocessor/PersistentHitQueue.swift
Outdated
Show resolved
Hide resolved
addb
requested review from
shalehaha and
praveek
and removed request for
sbenedicadb,
shalehaha and
praveek
January 8, 2021 20:51
Codecov Report
@@ Coverage Diff @@
## dev #496 +/- ##
==========================================
+ Coverage 87.70% 87.74% +0.04%
==========================================
Files 92 92
Lines 4113 4128 +15
==========================================
+ Hits 3607 3622 +15
Misses 506 506 |
AEPServices/Sources/utility/hitprocessor/PersistentHitQueue.swift
Outdated
Show resolved
Hide resolved
nporter-adbe
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added batchLimit to the PersistentHitQueue so the hits would be processed only after the queue size reaches batchLimit.
Related Issue
Motivation and Context
Batching is required for Analytics hits.
How Has This Been Tested?
Have added Unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: