Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batchLimit on PersistentHitQueue #496

Merged
merged 11 commits into from
Jan 13, 2021

Conversation

addb
Copy link
Contributor

@addb addb commented Jan 8, 2021

Description

Added batchLimit to the PersistentHitQueue so the hits would be processed only after the queue size reaches batchLimit.

Related Issue

Motivation and Context

Batching is required for Analytics hits.

How Has This Been Tested?

Have added Unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from shalehaha and praveek and removed request for sbenedicadb, shalehaha and praveek January 8, 2021 20:51
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #496 (c17a9bb) into dev (f78bf6b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #496      +/-   ##
==========================================
+ Coverage   87.70%   87.74%   +0.04%     
==========================================
  Files          92       92              
  Lines        4113     4128      +15     
==========================================
+ Hits         3607     3622      +15     
  Misses        506      506              

@shalehaha shalehaha merged commit b38d757 into adobe:dev Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants