Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow update: remove the option to skip verification #505

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

yangyansong-adbe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yangyansong-adbe
Copy link
Contributor Author

yangyansong-adbe commented Jan 15, 2021

@sbenedicadb, I have updated the release workflow, now we can't skip verification but create a new tag at the same CI job.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #505 (4b3c101) into main (c9abdd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files          92       92           
  Lines        4120     4120           
=======================================
  Hits         3620     3620           
  Misses        500      500           

@shalehaha shalehaha changed the base branch from main to dev-v3.0.0 January 15, 2021 20:38
@shalehaha shalehaha merged commit 8b5aa0f into dev-v3.0.0 Jan 15, 2021
@yangyansong-adbe yangyansong-adbe deleted the main-ci-update branch January 15, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants