Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss button not removing the temp file #606

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

ravjain-adb
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #606 (3961139) into dev-v3.1.1 (af9fe50) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@              Coverage Diff               @@
##           dev-v3.1.1     #606      +/-   ##
==============================================
- Coverage       85.09%   85.06%   -0.03%     
==============================================
  Files             102      102              
  Lines            4487     4490       +3     
==============================================
+ Hits             3818     3819       +1     
- Misses            669      671       +2     

@shalehaha shalehaha changed the base branch from dev-v3.1.1 to dev-v3.1.2 April 9, 2021 17:05
@shalehaha shalehaha merged commit 5a830ac into adobe:dev-v3.1.2 Apr 14, 2021
@shalehaha shalehaha added this to the v3.1.2 milestone Apr 29, 2021
@shalehaha shalehaha added coresquad bug Something isn't working. Used by issue templates labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Used by issue templates coresquad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants