Fetch latest configuration on identity bootup #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev-v3.1.2 #610 +/- ##
==============================================
+ Coverage 85.25% 85.32% +0.07%
==============================================
Files 102 102
Lines 4570 4571 +1
==============================================
+ Hits 3896 3900 +4
+ Misses 674 671 -3 |
nporter-adbe
commented
Apr 19, 2021
| @@ -53,6 +53,10 @@ class TestableExtensionRuntime: ExtensionRuntime { | |||
| } | |||
|
|
|||
| func getSharedState(extensionName: String, event: Event?, barrier: Bool) -> SharedStateResult? { | |||
| if event == nil { | |||
There was a problem hiding this comment.
We may need to make some other changes to the TestableRuntimes to ensure that it mimicks the EventHub behavior by fetching latest when a nil event is passed in.
shalehaha
approved these changes
Apr 22, 2021
|
Changes look good. Can we also add an e2e test with config & identity that covers the flow in the issue description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #608
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: