make rules engine code public #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev-v3.1.2 #612 +/- ##
==============================================
- Coverage 85.32% 85.27% -0.05%
==============================================
Files 102 104 +2
Lines 4571 4570 -1
==============================================
- Hits 3900 3897 -3
- Misses 671 673 +2 |
shalehaha
commented
Apr 23, 2021
|
|
||
| /// A rules engine for Launch rules | ||
| class LaunchRulesEngine { | ||
| private let LOG_TAG = "\(RulesConstants.LOG_MODULE_PREFIX) - LaunchRulesEngine" | ||
| public class LaunchRulesEngine { |
There was a problem hiding this comment.
need to find a better name for LaunchRulesEngine
sbenedicadb
reviewed
Apr 23, 2021
| public struct RuleConsequence { | ||
| let id: String | ||
| let type: String | ||
| var detailDict: [String: Any?] |
There was a problem hiding this comment.
can we change this var name to details?
sbenedicadb
reviewed
Apr 23, 2021
| @@ -0,0 +1,24 @@ | |||
| /* | |||
| Copyright 2020 Adobe. All rights reserved. | |||
sbenedicadb
reviewed
Apr 23, 2021
|
|
||
| init(name: String, extensionRuntime: ExtensionRuntime) { | ||
| public init(name: String, extensionRuntime: ExtensionRuntime) { |
There was a problem hiding this comment.
would be good to get some in-code documentation here, especially for public apis
yangyansong-adbe
approved these changes
Apr 26, 2021
| } | ||
|
|
||
| guard let rules = JSONRulesParser.parse(data) else { | ||
| return |
There was a problem hiding this comment.
need to combine guards and print log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
public func replaceRules(with rules: [LaunchRule])public func process(event: Event) -> Eventfunc replaceRules(from urlString: String)func replaceRulesWithCache(from urlString: String)Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: