Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug where session was not reused for the same domain #614

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

shalehaha
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@sbenedicadb sbenedicadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, good catch.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #614 (5b6af89) into dev-v3.1.2 (18d463f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           dev-v3.1.2     #614      +/-   ##
==============================================
+ Coverage       85.27%   85.30%   +0.02%     
==============================================
  Files             104      104              
  Lines            4570     4570              
==============================================
+ Hits             3897     3898       +1     
+ Misses            673      672       -1     

@shalehaha shalehaha merged commit 4d5ae92 into adobe:dev-v3.1.2 Apr 28, 2021
@shalehaha shalehaha added coresquad bug Something isn't working. Used by issue templates labels Apr 29, 2021
@shalehaha shalehaha added this to the v3.1.2 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Used by issue templates coresquad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants