Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMSDK-11543] Fix data race in Extension container #684

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[AMSDK-11543] Fix data race in Extension container #684

merged 1 commit into from
Aug 12, 2021

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Aug 10, 2021

Fix a data race in Extension container where lastProcessedEvent is accessed from different threads.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@praveek praveek changed the base branch from main to dev-v3.2.4 August 10, 2021 17:56
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #684 (0a67679) into dev-v3.2.4 (69b84a3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           dev-v3.2.4     #684      +/-   ##
==============================================
+ Coverage       85.31%   85.34%   +0.03%     
==============================================
  Files             105      105              
  Lines            4644     4652       +8     
==============================================
+ Hits             3962     3970       +8     
  Misses            682      682              

Copy link
Member

@sbenedicadb sbenedicadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@praveek praveek merged commit 3e72716 into adobe:dev-v3.2.4 Aug 12, 2021
@praveek praveek added this to the v3.2.4 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants