[MOB-19513] Migration logic #968
Conversation
Codecov Report
@@ Coverage Diff @@
## migrateOffUserDefaults #968 +/- ##
==========================================================
+ Coverage 89.99% 90.08% +0.09%
==========================================================
Files 131 133 +2
Lines 8221 8279 +58
==========================================================
+ Hits 7398 7458 +60
+ Misses 823 821 -2 |
| } | ||
|
|
||
| private func needToMigrate() -> Bool { | ||
| let installDateKey = keyWithPrefix(datastoreName: constants.Lifecycle.DATASTORE_NAME, key: constants.Lifecycle.DataStoreKeys.INSTALL_DATE.rawValue) |
There was a problem hiding this comment.
We should not do the migration based on this key as it will be present only for customers using Lifecycle extension.
I can't think of a key to use as a basis for the migration as even our config keys won't be available when using bundled configuration. Can you run the migration logic with out the needToMigrate check as it should become a no-op after the first run?
There was a problem hiding this comment.
I was following the pattern we use for the other migrators. Do you think we should add a key to our DataStore post migration that we can check later to avoid running through the loops on every launch?
|
|
||
| private func getAndDelete(key: String) -> Any? { | ||
| guard let value = defaults.object(forKey: key) else { | ||
| Log.debug(label: LOG_TAG, "Failed to get value to migrate from UserDefaults") |
There was a problem hiding this comment.
nit: I'd prefer to use language other than "failed" here -- as we fully expect a bunch of the keys to not exist (Depending on implementation). Can we change to a verbose log and change verbiage to "No value for (key) found."
| enum UserDefaultMigratorConstants { | ||
|
|
||
| static let MIGRATION_STORE_NAME = "com.adobe.migration" | ||
| static let MIGRATION_COMPLETE = "migrationComplete" |
There was a problem hiding this comment.
Can you also change the value to also track the type of migration that was done? migration.userdefaults.complete
The migration logic for migrating data from UserDefaults to new datastore