Modify cache to not read file modification date #969
Conversation
Codecov Report
@@ Coverage Diff @@
## migrateOffUserDefaults #969 +/- ##
==========================================================
- Coverage 90.07% 89.78% -0.29%
==========================================================
Files 133 133
Lines 8321 8330 +9
==========================================================
- Hits 7495 7479 -16
- Misses 826 851 +25 |
| @@ -49,7 +49,7 @@ class FileSystemNamedCollection: NamedCollectionProcessing { | |||
| do { | |||
| try updatedStorageData.write(to: fileUrl, options: .atomic) | |||
| } catch { | |||
| Log.warning(label: self.LOG_TAG, "Error when writing to file: \(error)") | |||
| Log.warning(label: self.LOG_TAG, "Error \(error) when writing \(key) to collection \(collectionName)") | |||
There was a problem hiding this comment.
i would vote to put our dynamic content in single quotes so it's clear to the reader exactly where the error, key, and collection name begin and end. should we also announce key (e.g. - ...when writing key '\(key)') like we are for the other variables and in the subsequent log?
| guard let storageData = try? Data(contentsOf: fileUrl) else { | ||
| return nil | ||
| } | ||
|
|
||
| guard let jsonResult = try? JSONSerialization.jsonObject(with: storageData) as? [String: Any] else { | ||
| Log.warning(label: LOG_TAG, "Failed to read dictionary from collection \(collectionName)") | ||
| return nil | ||
| } | ||
| Log.warning(label: LOG_TAG, "Failed to get Dictionary from data store") | ||
| return nil | ||
|
|
||
| return jsonResult |
| return jsonResult | ||
| } | ||
| guard let storageData = try? Data(contentsOf: fileUrl) else { | ||
| return nil |
There was a problem hiding this comment.
should we provide a message here indicating we were unable to retrieve the file contents?
There was a problem hiding this comment.
This is causing a lot of false warnings during a new install.
| } | ||
|
|
||
| // As date stores the timestamp in milliseconds, compare double value with accuracy greater than milliseconds. | ||
| let accuracy = 0.00001; |
There was a problem hiding this comment.
wouldn't this just be 0.001? my two cents is we could make it even a little more forgiving than this so we don't have random failures with this equality check
…sdk-core-ios into migrateOffUserDefaults
This change will cause a one time cache miss for currently cached content.
Fixed
IdentityIntegrationTests .testGetExperienceCloudIdWithinPermissibleTimeOnInstall- #954