Add attribute for fileprotection #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveek
reviewed
Oct 16, 2023
| @@ -126,6 +126,7 @@ class FileSystemNamedCollection: NamedCollectionProcessing { | |||
| let adobeBaseUrl = baseUrl.appendingPathComponent(adobeDirectory, isDirectory: true) | |||
| do { | |||
| try fileManager.createDirectory(at: adobeBaseUrl, withIntermediateDirectories: true) | |||
| try fileManager.setAttributes([FileAttributeKey.protectionKey: FileProtectionType.none], ofItemAtPath: adobeBaseUrl.path) | |||
| } catch { | |||
| Log.error(label: adobeDirectory, "Failed to create storage directory with error: \(error)") | |||
There was a problem hiding this comment.
Should we consider adjusting this error message? Is it possible to check the reason and avoid printing this message when the error is a result of the directory already existing?
There was a problem hiding this comment.
It doesn't error when the directory exists. It simply doesn't do anything when the directory exists.
Codecov Report
@@ Coverage Diff @@
## migrateOffUserDefaults #971 +/- ##
==========================================================
+ Coverage 90.08% 90.11% +0.03%
==========================================================
Files 133 133
Lines 8279 8280 +1
==========================================================
+ Hits 7458 7461 +3
+ Misses 821 819 -2 |
praveek
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an attribute for our FileSystem storage directory and sets the fileprotection to none. This is to avoid system restrictions during app backgrounding and other potential edge cases.
Also adds capabilities to our test app for testing backgrounding tasks.