[MOB-19790] Fix encoded data in migration #974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash which happened when trying to set Data in FileSystemNamedCollection.
The crash occurred because the JSONSerialization.data(:_) method crashes internally when a top level fragment is not an accepted type. See here. When we attempted to set encoded data, the crash occurs.
To avoid the crash, we use the
JSONSerialization.isValidJSONObject
to check if the value can be used.To successfully migrate the encoded data, we now encode the data as a string in the migrator before migrating it.