Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-fix wrong string in MessageGestures, ran formatting #995

Merged
merged 3 commits into from Feb 29, 2024

Conversation

sbenedicadb
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #995 (591a474) into dev-v5.0.0 (c015f49) will not change coverage.
Report is 16 commits behind head on dev-v5.0.0.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-v5.0.0     #995   +/-   ##
===========================================
  Coverage       89.67%   89.67%           
===========================================
  Files             133      133           
  Lines            8338     8338           
===========================================
  Hits             7477     7477           
  Misses            861      861           

Podfile.lock Outdated
@@ -17,4 +17,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: acb2eae490811dde6b01fe47b58f15a93d08247f

COCOAPODS: 1.14.3
COCOAPODS: 1.15.0
Copy link
Contributor

@praveek praveek Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a Gemfile which locks the dependency to 1.14.3. Can you revert this change?

@praveek praveek merged commit 0ddd920 into adobe:dev-v5.0.0 Feb 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants