Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventType Key in code #129

Merged
merged 2 commits into from Jan 6, 2024
Merged

Remove EventType Key in code #129

merged 2 commits into from Jan 6, 2024

Conversation

PravinPK
Copy link
Contributor

Description

Remove the unwanted eventType key from constants file

Related Issue

Motivation and Context

This key seems to be confusing as eventType field is not mandatory for Experience edge events

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #129 (759bbfa) into main (2519205) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #129   +/-   ##
=========================================
  Coverage     84.30%   84.30%           
  Complexity      406      406           
=========================================
  Files            30       30           
  Lines          1643     1643           
  Branches        235      235           
=========================================
  Hits           1385     1385           
  Misses          165      165           
  Partials         93       93           
Flag Coverage Δ
functional-tests 67.07% <ø> (ø)
unit-tests 80.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eventType field is not required to be set by customer, but we do recommend setting it. We set an eventType when creating internal experience events, but that is done in other extensions, so it looks like this variable isn't needed.
Can you also clean up the other XDM variables as mentioned in the comments? It looks like EVENT_ID, TIMESTAMP, and IDENTITY_MAP are the only ones used in production.

@emdobrin emdobrin changed the base branch from main to dev-v2.4.1 January 5, 2024 22:04
@kevinlind kevinlind merged commit 7e293dc into dev-v2.4.1 Jan 6, 2024
7 checks passed
@kevinlind kevinlind deleted the pravinPatch branch January 6, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants