New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Gradle files to use aep-plugin library #131
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.0.0 #131 +/- ##
================================================
+ Coverage 80.34% 84.43% +4.09%
- Complexity 398 405 +7
================================================
Files 30 30
Lines 1643 1638 -5
Branches 235 235
================================================
+ Hits 1320 1383 +63
+ Misses 227 162 -65
+ Partials 96 93 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -60,7 +60,7 @@ jobs: | |||
# List of available Android Docker images: https://circleci.com/developer/images/image/cimg/android#image-tags | |||
executor: | |||
name: android/android-docker | |||
tag: 2022.09.2-node | |||
tag: 2024.01.1-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's difference between 2024.01.1-node and 2024.01.1?
Other extensions are using 2024.01.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-node
includes Node.js in the image, which is required when using Spotless + Prettier.
…Makefile as these dependencies are already set in the Gradle files.
} | ||
|
||
android { | ||
namespace = "com.adobe.marketing.tester" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to refactor the app name space to unique namespace
com.adobe.marketing.mobile..testapp
Make sure the app name follows similar naming (ex UserProfile Test App).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The namespace matches the directory structure, so I'll need to move and update all the test app files. I'll do this in another PR.
Description
Updates the Edge Gradle files, migrating from Groovy to Kotlin versions, and use the aep-plugin library.
Updates the CircleCi configuration's orb and image versions.
Updates the GitHub workflow publish scripts to use JDK 17 plus create the GH tag/version on main publish.
Adds GitHub workflow version script, same as Core, to update project version from GH Actions.
Removes use of deprecated MobileCore.registerExtension and updates Function test cases which used the API.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: