Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gradle files to use aep-plugin library #131

Merged
merged 21 commits into from Feb 14, 2024

Conversation

kevinlind
Copy link
Contributor

Description

Updates the Edge Gradle files, migrating from Groovy to Kotlin versions, and use the aep-plugin library.
Updates the CircleCi configuration's orb and image versions.
Updates the GitHub workflow publish scripts to use JDK 17 plus create the GH tag/version on main publish.
Adds GitHub workflow version script, same as Core, to update project version from GH Actions.
Removes use of deprecated MobileCore.registerExtension and updates Function test cases which used the API.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Merging #131 (a941e2b) into dev-v3.0.0 (c449867) will increase coverage by 4.09%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             dev-v3.0.0     #131      +/-   ##
================================================
+ Coverage         80.34%   84.43%   +4.09%     
- Complexity          398      405       +7     
================================================
  Files                30       30              
  Lines              1643     1638       -5     
  Branches            235      235              
================================================
+ Hits               1320     1383      +63     
+ Misses              227      162      -65     
+ Partials             96       93       -3     
Flag Coverage Δ
-tests 84.43% <ø> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/main/java/com/adobe/marketing/mobile/Edge.java 62.50% <ø> (+13.22%) ⬆️
...java/com/adobe/marketing/mobile/EdgeConstants.java 66.67% <ø> (ø)
...ava/com/adobe/marketing/mobile/EdgeDataEntity.java 86.05% <ø> (ø)
...java/com/adobe/marketing/mobile/EdgeExtension.java 85.26% <ø> (+11.54%) ⬆️

... and 9 files with indirect coverage changes

@@ -60,7 +60,7 @@ jobs:
# List of available Android Docker images: https://circleci.com/developer/images/image/cimg/android#image-tags
executor:
name: android/android-docker
tag: 2022.09.2-node
tag: 2024.01.1-node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's difference between 2024.01.1-node and 2024.01.1?
Other extensions are using 2024.01.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-node includes Node.js in the image, which is required when using Spotless + Prettier.

Makefile Show resolved Hide resolved
}

android {
namespace = "com.adobe.marketing.tester"
Copy link
Contributor

@cacheung cacheung Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to refactor the app name space to unique namespace
com.adobe.marketing.mobile..testapp

Make sure the app name follows similar naming (ex UserProfile Test App).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace matches the directory structure, so I'll need to move and update all the test app files. I'll do this in another PR.

@kevinlind kevinlind merged commit 5e2f171 into adobe:dev-v3.0.0 Feb 14, 2024
7 checks passed
@kevinlind kevinlind deleted the use-kotlin-gradle branch February 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants