Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'asNode(null)' to 'asNode()'. #87

Merged
merged 1 commit into from Aug 25, 2023

Conversation

kevinlind
Copy link
Contributor

Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step.
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #87 (0d7d2a8) into dev-v2.3.0 (5d322f8) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.3.0      #87   +/-   ##
=============================================
  Coverage         83.84%   83.84%           
  Complexity          385      385           
=============================================
  Files                29       29           
  Lines              1578     1578           
  Branches            223      223           
=============================================
  Hits               1323     1323           
  Misses              161      161           
  Partials             94       94           
Flag Coverage Δ
functional-tests 66.48% <ø> (ø)
unit-tests 79.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kevinlind kevinlind merged commit 2773a7d into adobe:dev-v2.3.0 Aug 25, 2023
7 checks passed
@kevinlind kevinlind deleted the fix-gradle branch August 25, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants