Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache config with Edge event #367

Closed
emdobrin opened this issue Jul 14, 2023 · 0 comments · Fixed by #458
Closed

Cache config with Edge event #367

emdobrin opened this issue Jul 14, 2023 · 0 comments · Fixed by #458
Assignees
@kevinlind
Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates

Comments

@emdobrin
Copy link
Contributor

Task description

For consistency with Android, we should cache the Edge config settings with the Event.

  • Update EventDataEntity to include config and update EdgeHitProcessor to use this instead of retrieving right before processing.
  • Update relevant tests and/or add new ones.

Additional implementation details or code snippet(s)

No response
@emdobrin emdobrin added the task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates label Jul 14, 2023
@kevinlind kevinlind self-assigned this Apr 8, 2024
@kevinlind kevinlind linked a pull request Apr 17, 2024 that will close this issue
Cache configuration with Edge hit (resolves #367) #458
Merged
10 tasks
kevinlind added a commit that referenced this issue Apr 26, 2024
@kevinlind
Cache configuration with Edge hit (resolves #367) (#458)
3c04830 
* Add configuration to EdgeDataEntity.

* Update processHit to retrieve configuration from EdgeDataEntity while preserving older workflow.

* Update EdgeHitProcessorTests to set configuration in EdgeDataEntity

* Add functional tests which validate queued entities are processed correctly.

* Change order of 'if' to place most common path first.

* Update log message when edge.configId is missing or empty.

* Factor out code to get Edge configuration to reduce func lines of code.

* Factor out common check on event.data

* Consolidate common code to create and queue data entity in functional tests.

* Refactor common getEdgeConfig logic

* Use JSON asserts for EdgeExtensionTests

* Update function comments for getDataQueue

* Remove getXDMSharedState closure from EdgeHitProcessor as it is not used.

* Add SharedStateReader for EdgeHitProcessor to retrieve state data

* Wait for consent value to be set before continuing testing

* Update function comment to correct 'returns' statement

* Suspend hit queue after updating Consent status to capture hits in EdgeExtensionTests
@addb addb closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinlind kevinlind

Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache configuration with Edge hit (resolves #367) kevinlind/aepsdk-edge-ios
3 participants
@addb @emdobrin @kevinlind