dev -> staging v4.0.0 release #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main -> Dev
…sending lot of internal playhead updates (#63) * Fix timer not firing issue * Update tick timer to be just over 1 second to avoid conflicting with customer playhead update * Set timer repeat interval to 1second * Use dispatchSourceTimer to run timer on the background thread and use the existing dispatchQueue * Update Makefile and circleci config.yaml * fix make command * Updates based on reviews * Fix the event timeout and tick interval * Increase timeout to reduce test flakiness
…nd iOS 11 (#66) * min version support min version support * update for lint errors update for lint errors * Lint warning fixes Lint warning fixes * Fix lint errors and review changes --------- Co-authored-by: Arjun Bhadra <abhadra@adobe.com>
* min version support min version support * update for lint errors update for lint errors * Lint warning fixes Lint warning fixes * With Lint setup for test With Lint setup for test * Lint fixes Lint fixes * Fix lint errors * Review fixes --------- Co-authored-by: Arjun Bhadra <abhadra@adobe.com>
addb
approved these changes
Jun 8, 2023
addb
approved these changes
Jun 8, 2023
addb
approved these changes
Jun 8, 2023
cacheung
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## staging #68 +/- ##
===========================================
+ Coverage 92.50% 94.02% +1.52%
===========================================
Files 28 28
Lines 2188 3163 +975
===========================================
+ Hits 2024 2974 +950
- Misses 164 189 +25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: