Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to set accuracyAuthorization #11

Merged
merged 7 commits into from
May 28, 2021

Conversation

sbenedicadb
Copy link
Member

No description provided.

@sbenedicadb sbenedicadb requested a review from PravinPK May 28, 2021 16:48
@@ -62,6 +62,10 @@ class ViewController: UIViewController {
}
}

@IBAction func setAccuracyAuthorization(_ sender: Any) {
Places.setAccuracyAuthorization(accuracy: .fullAccuracy)
Copy link
Contributor

@PravinPK PravinPK May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add

        if #available(iOS 14, *) {
            Places.setAccuracyAuthorization(accuracy: .fullAccuracy)
        }

as this API is only available 14+
same for the ObjectiveC sample app

}

return nil
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if the enum CLAccuracyAuthorization available only after iOS 14

should we wrap the complete accuracy property with #available(iOS 14, *)
I do see this being compile properly on iOS 13 devices.. But wonder how

@sbenedicadb sbenedicadb merged commit 91d1b95 into adobe:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants