-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for X-EXC-SDK and X-EXC-SDK-Version headers #29
Conversation
} | ||
|
||
/** | ||
* Runs the Target SDK info containing platform and wrapper details in the format {@literal AdobeTargetMobile-Android<-wrapperFriendlyName>}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: should be Returns the Target SDK...
/** | ||
* Gets the latest valid {@code EventHub} shared state at the given {@code event} version. | ||
* | ||
* @param event the {@code EventHub} state version to retrieve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me with just a couple of java doc updates to be made. feel free to merge after resolving.
* Added support for X-EXC-SDK and X-EXC-SDK-Version headers (#29) * Update build.gradle * Added support for X-EXC-SDK and X-EXC-SDK-Version headers * Fixed minor checkstyle issue * Fixed failing unit tests * Minor fixes * Using the Core API for fetching the extension version in functional tests * cleanup * Feedback updates --------- Co-authored-by: Praveen <praveek@users.noreply.github.com> * Added tests to bump up coverage when using Target headers (#31) * Update build.gradle * Bump up coverage for MOB-18912 --------- Co-authored-by: Praveen <praveek@users.noreply.github.com> --------- Co-authored-by: Ryan Morales <rymorale@adobe.com> Co-authored-by: Praveen <praveek@users.noreply.github.com>
* Added support for X-EXC-SDK and X-EXC-SDK-Version headers (#29) * Update build.gradle * Added support for X-EXC-SDK and X-EXC-SDK-Version headers * Fixed minor checkstyle issue * Fixed failing unit tests * Minor fixes * Using the Core API for fetching the extension version in functional tests * cleanup * Feedback updates --------- * Added tests to bump up coverage when using Target headers (#31) * Update build.gradle * Bump up coverage for MOB-18912 --------- --------- Co-authored-by: Ryan Morales <rymorale@adobe.com> Co-authored-by: Praveen <praveek@users.noreply.github.com>
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: