Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make archive fails to build #107

Closed
markph0204 opened this issue Nov 10, 2021 · 1 comment
Closed

make archive fails to build #107

markph0204 opened this issue Nov 10, 2021 · 1 comment
Assignees

Comments

@markph0204
Copy link

Expected Behavior

After running make archive, we expect the build to not fail and output frameworks to the build path.

Actual Behavior

Makefile fails to build XCFramework's successfully.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Get project fresh (git clone) from this repo.
  2. run make archive from terminal

Platform and Version

Mac OS version Big Sur 11.6.1 using Xcode 13.1

Sample Code that illustrates the problem

Not code related.

Logs taken while reproducing problem

Corrective action is suggested in two areas:

  1. Notify the user to run pod install in the README.md file
  2. the swiftformat dependency is missing, and is needed to complete archive. Suggest the user not be required to install it themselves, since CocoaPods is being used for other. Instead leverage CocoaPods to also install swiftformat dependency. This also includes a subtle change in XCodeProject to use swiftformat installed in PODS rather than environment. This affords you with ability to "pin" a specific swiftformat version in future as well for compatibility reasons if ever needed.

Also noteworthy -- why is this repo using swiftformat while other Adobe modules are using SwiftLint? Consistency?

@swarna04
Copy link
Contributor

hi @markph0204 , Thank you for reporting this issue. We have updated the README file as suggested and also updated the run script build phase to use SwiftLint for consistency. The SwiftLint (v0.44.0) can now be installed as a pod dependency. You should not see any issues with running make archive now. Thank you.

@swarna04 swarna04 self-assigned this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants