You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After running make archive, we expect the build to not fail and output frameworks to the build path.
Actual Behavior
Makefile fails to build XCFramework's successfully.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Get project fresh (git clone) from this repo.
run make archive from terminal
Platform and Version
Mac OS version Big Sur 11.6.1 using Xcode 13.1
Sample Code that illustrates the problem
Not code related.
Logs taken while reproducing problem
Corrective action is suggested in two areas:
Notify the user to run pod install in the README.md file
the swiftformat dependency is missing, and is needed to complete archive. Suggest the user not be required to install it themselves, since CocoaPods is being used for other. Instead leverage CocoaPods to also install swiftformat dependency. This also includes a subtle change in XCodeProject to use swiftformat installed in PODS rather than environment. This affords you with ability to "pin" a specific swiftformat version in future as well for compatibility reasons if ever needed.
Also noteworthy -- why is this repo using swiftformat while other Adobe modules are using SwiftLint? Consistency?
The text was updated successfully, but these errors were encountered:
hi @markph0204 , Thank you for reporting this issue. We have updated the README file as suggested and also updated the run script build phase to use SwiftLint for consistency. The SwiftLint (v0.44.0) can now be installed as a pod dependency. You should not see any issues with running make archive now. Thank you.
Expected Behavior
After running make archive, we expect the build to not fail and output frameworks to the build path.
Actual Behavior
Makefile fails to build XCFramework's successfully.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Mac OS version Big Sur 11.6.1 using Xcode 13.1
Sample Code that illustrates the problem
Not code related.
Logs taken while reproducing problem
Corrective action is suggested in two areas:
pod install
in the README.md fileAlso noteworthy -- why is this repo using swiftformat while other Adobe modules are using SwiftLint? Consistency?
The text was updated successfully, but these errors were encountered: