Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev to staging (v4.0.3) #156

Merged
merged 2 commits into from
Jan 26, 2024
Merged

dev to staging (v4.0.3) #156

merged 2 commits into from
Jan 26, 2024

Conversation

swarna04
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sbenedicadb and others added 2 commits October 12, 2023 08:31
staging to main for 4.0.2 release
…nt data callback (#155)

* Target SDK should attach response tokens in the retrieveLocationContent data callback

* Minor fixes

* • reverted dependency updates
 • updated test constants

* revert podfile.lock

* Fixed tests after migration from UserDefaults to file system.

* minor cleanup

* Additional test + doc update
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #156 (4744078) into staging (1f6eba0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #156   +/-   ##
========================================
  Coverage    92.16%   92.16%           
========================================
  Files           25       25           
  Lines         2232     2232           
========================================
  Hits          2057     2057           
  Misses         175      175           

Copy link
Member

@sbenedicadb sbenedicadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@swarna04 swarna04 merged commit 13c4a82 into staging Jan 26, 2024
7 checks passed
swarna04 added a commit that referenced this pull request Jan 26, 2024
…nt data callback (#155) (#156) (#157)

* Target SDK should attach response tokens in the retrieveLocationContent data callback

* Minor fixes

* • reverted dependency updates
 • updated test constants

* revert podfile.lock

* Fixed tests after migration from UserDefaults to file system.

* minor cleanup

* Additional test + doc update

Co-authored-by: Steve Benedick <sbenedic@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants