project init #1
Merged
project init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalehaha
reviewed
Oct 22, 2020
| self.updateAttributes(event) | ||
| } else if event.isGetAttributesEvent { | ||
| self.getAttributes(event) | ||
| } |
There was a problem hiding this comment.
log a trace message if the event doesn't match either of the check
| public func onUnregistered() {} | ||
|
|
||
| public func readyForEvent(_ event: Event) -> Bool { | ||
| return getSharedState(extensionName: UserProfileConstants.Configuration.NAME, event: event)?.status == .set |
There was a problem hiding this comment.
don't think we need configuration shared state. Are we doing this check in v5?
| /// - Parameter event: the RulesEngine response event | ||
| private func handleRulesEngineResponse(event: Event) { | ||
| guard event.isRulesConsequenceEvent, event.consequenceType == UserProfileConstants.RulesEngine.CONSEQUENCE_KEY_CSP else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process this event: not a RulesEngine response event for UserProfile extension") |
There was a problem hiding this comment.
don't think we need this log, or make it a trace log.
| /// - Parameter event: the request event | ||
| private func updateAttributes(_ event: Event) { | ||
| guard let newAttributes = event.data?[UserProfileConstants.UserProfile.EventDataKeys.UPDATE_DATA_KEY] as? [String: Any], !newAttributes.isEmpty else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process the update attributes event: not found valid event data") |
There was a problem hiding this comment.
Unable to process the update attributes event: invalid event data
| private func getAttributes(_ event: Event) { | ||
| guard let keys = event.data?[UserProfileConstants.UserProfile.EventDataKeys.GET_DATA_ATTRIBUTES] as? [String], !keys.isEmpty else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process the get attributes event: not found valid event data") | ||
| return |
There was a problem hiding this comment.
I think we should also dispatch a respsone event here, to invoke the one time listener
| attributes.removeValue(forKey: key) | ||
| } | ||
| guard attributesCount != attributes.count else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process the remove attributes event: not found attributes for given keys - \(keys)") |
There was a problem hiding this comment.
Unable to process the remove attributes event: no attributes matched with the given keys - (keys)
| /// - Parameter event: the request event | ||
| private func getAttributes(_ event: Event) { | ||
| guard let keys = event.data?[UserProfileConstants.UserProfile.EventDataKeys.GET_DATA_ATTRIBUTES] as? [String], !keys.isEmpty else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process the get attributes event: not found valid event data") |
| /// - Parameter event: the request event | ||
| private func removeAttributes(event: Event) { | ||
| guard let keys = event.data?[UserProfileConstants.UserProfile.EventDataKeys.REMOVE_DATA_KEYS] as? [String], !keys.isEmpty else { | ||
| Log.debug(label: UserProfile.LOG_TAG, "Unable to process the remove attributes event: not found valid event data") |
There was a problem hiding this comment.
Unable to process the update attributes event: invalid event data
| /// - Parameters: | ||
| /// - attributeName: the attribute's key | ||
| /// - attributeValue: the attribute's value | ||
| static func updateUserAttribute(attributeName: String, attributeValue: String?) { |
There was a problem hiding this comment.
i'm wondering whether we need this API and the removeUserAttribute API
There was a problem hiding this comment.
yes, we can remove those 2 APIs, and only make them available in the Objective-C compatibility layer.
yangyansong-adbe
referenced
this pull request
in yangyansong-adbe/aepsdk-userprofile-ios
Nov 2, 2020
* commit '2ed7547ef954b343639806b73e3a2d7099d241e7': Update .swiftformat setup E2E (manual) testings target (adobe#17) Update README.md Update README.md Update readme.md (adobe#16) Update codecov.yml Update swift.yml (adobe#15) Response to review feedback (adobe#14) fix spm instructions Update README.md Update README.md add docs (adobe#13) review feedback WIP: project init (#1)
yangyansong-adbe
added a commit
that referenced
this pull request
Nov 2, 2020
* commit '2ed7547ef954b343639806b73e3a2d7099d241e7': Update .swiftformat setup E2E (manual) testings target (#17) Update README.md Update README.md Update readme.md (#16) Update codecov.yml Update swift.yml (#15) Response to review feedback (#14) fix spm instructions Update README.md Update README.md add docs (#13) review feedback WIP: project init (#1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.