Dev v5.0.0 to staging #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update for major version 5.0
Log tag is used by other extensions for migration logic logging.
Fix tests and build failure
…s into dev-v5.0.0
Update Xcode version in GH Actions
Point to staging for testing 5.x
sbenedicadb
reviewed
Mar 14, 2024
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: 14.1 | ||
| xcode-version: 15.0.1 |
There was a problem hiding this comment.
I kept it on 15.0.1 because the slow performance didn't seem to affect this extensions tests passing. I'm open to swapping to 15.1 to match other extensions though? I mostly thought it would be nice to keep on parity with the release Xcode version if possible.
There was a problem hiding this comment.
I kept it on 15.0.1 because the slow performance didn't seem to affect this extensions tests passing. I'm open to swapping to 15.1 to match other extensions though? I mostly thought it would be nice to keep on parity with the release Xcode version if possible.
sbenedicadb
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: