Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone app deploy fails imsOrgId must be defined #36

Open
hthakkar2905 opened this issue May 9, 2023 · 3 comments
Open

Standalone app deploy fails imsOrgId must be defined #36

hthakkar2905 opened this issue May 9, 2023 · 3 comments

Comments

@hthakkar2905
Copy link

hthakkar2905 commented May 9, 2023

Expected Behaviour

App gets deployed with CI CD.

Actual Behaviour

Deployment fails with error "imsOrgId must be defined"

Reproduce Scenario (including but not limited to)

  1. Create a standalone app using aio CLI that has action only

Steps to Reproduce

  1. Create a standalone app with action only
  2. Make sure github workflow yml is configured as per documentation
  3. Deploy using github CI CD

Platform and Version

Sample Code that illustrates the problem

Attached screenshots of code structure and how deployment yml looks like.

Logs taken while reproducing problem

Screenshot 2023-05-09 at 2 47 39 pm
Screenshot 2023-05-09 at 2 47 25 pm

@aguacatedan
Copy link

I've been struggling with this issue the past few days as well and I went through the very painful process of reading the source code to understand what exactly I was missing.

In short, I solved this by setting my IMS Org ID in the CI/CD pipeline prior to the deploy command:
aio config:set -l project.org.ims_org_id foobar@AdobeOrg

This sets the ims_org_id in the project's local .aio config file. If you look at yours in your IDE, you'll see it's already set and that probably happened sometime during aio app init. So rather than adding this config file to source control, adding that config property through the CLI did it for me.

I did find some interesting comments in the cli source code hinting that this imsOrgId property will be going away sometime in the future, but I didn't find any information in the official docs:

@hthakkar2905
Copy link
Author

hthakkar2905 commented May 11, 2023

Hi @aguacatedan
Yeah setting up IMS org id in previous step fixed it. Thanks for your help.

I just added additional step before deploy like this

- name: Set IMS Org ID
        run: |
          aio config:set -l project.org.ims_org_id ${{ secrets.IMSORGID_STAGE }}

@MichaelGoberling
Copy link
Contributor

@hthakkar2905 @aguacatedan

Is this issue still present with the latest version (3.3.0) if you remove the step to setup the IMS Org ID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants