fix: support object as action.input type (#36)

adobe · Apr 11, 2024 · e3c27e3 · e3c27e3
1 parent 9a1fcd1
commit e3c27e3
Show file tree

Hide file tree

Showing 6 changed files with 51 additions and 2 deletions.
diff --git a/schema/app.config.yaml.schema.json b/schema/app.config.yaml.schema.json
@@ -140,7 +140,7 @@
       "type": "object",
       "patternProperties": {
         "^[^\n]+$": {
-          "type": ["string", "boolean"]
+          "type": ["string", "boolean", "object"]
         }
       },
       "additionalProperties": false

diff --git a/test/__fixtures__/app-exc-nui/app.config.yaml b/test/__fixtures__/app-exc-nui/app.config.yaml
@@ -13,6 +13,10 @@ application:
             runtime: 'nodejs:14'
             inputs:
               LOG_LEVEL: 'debug'
+              SOMETHING:
+                type: string
+                description: this is about something
+                default: ''
             annotations:
               'require-adobe-auth': true
               final: true

diff --git a/test/__fixtures__/app/app.config.yaml b/test/__fixtures__/app/app.config.yaml
@@ -13,6 +13,10 @@ application:
             runtime: 'nodejs:14'
             inputs:
               LOG_LEVEL: 'debug'
+              SOMETHING:
+                type: string
+                description: this is about something
+                default: ''
             annotations:
               'require-adobe-auth': true
               final: true

diff --git a/test/__fixtures__/legacy-app/manifest.yml b/test/__fixtures__/legacy-app/manifest.yml
@@ -8,6 +8,10 @@ packages:
         runtime: 'nodejs:14'
         inputs:
           LOG_LEVEL: 'debug'
+          SOMETHING:
+            type: string
+            description: this is about something
+            default: ''
         annotations:
           'require-adobe-auth': true
           final: true

diff --git a/test/data-mocks/config-loader-include-index.js b/test/data-mocks/config-loader-include-index.js
@@ -179,6 +179,22 @@ const appIncludeIndex = {
     file: 'app.config.yaml',
     key: 'application.runtimeManifest.packages.my-app-package.actions.action.inputs.LOG_LEVEL'
   },
+  'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING': {
+    file: 'app.config.yaml',
+    key: 'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING'
+  },
+  'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.default': {
+    file: 'app.config.yaml',
+    key: 'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.default'
+  },
+  'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.description': {
+    file: 'app.config.yaml',
+    key: 'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.description'
+  },
+  'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.type': {
+    file: 'app.config.yaml',
+    key: 'application.runtimeManifest.packages.my-app-package.actions.action.inputs.SOMETHING.type'
+  },
   'application.runtimeManifest.packages.my-app-package.actions.action.runtime': {
     file: 'app.config.yaml',
     key: 'application.runtimeManifest.packages.my-app-package.actions.action.runtime'
@@ -622,6 +638,22 @@ const legacyIncludeIndex = {
     file: 'manifest.yml',
     key: 'packages.__APP_PACKAGE__.actions.action.inputs.LOG_LEVEL'
   },
+  'application.runtimeManifest.packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING': {
+    file: 'manifest.yml',
+    key: 'packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING'
+  },
+  'application.runtimeManifest.packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.default': {
+    file: 'manifest.yml',
+    key: 'packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.default'
+  },
+  'application.runtimeManifest.packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.description': {
+    file: 'manifest.yml',
+    key: 'packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.description'
+  },
+  'application.runtimeManifest.packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.type': {
+    file: 'manifest.yml',
+    key: 'packages.__APP_PACKAGE__.actions.action.inputs.SOMETHING.type'
+  },
   'application.runtimeManifest.packages.__APP_PACKAGE__.actions.action.runtime': {
     file: 'manifest.yml',
     key: 'packages.__APP_PACKAGE__.actions.action.runtime'

diff --git a/test/data-mocks/config-loader.js b/test/data-mocks/config-loader.js
@@ -45,7 +45,12 @@ function fullFakeRuntimeManifest (pathToActionFolder, pkgName1) {
             web: 'yes',
             runtime: 'nodejs:14',
             inputs: {
-              LOG_LEVEL: 'debug'
+              LOG_LEVEL: 'debug',
+              SOMETHING: {
+                type: 'string',
+                description: 'this is about something',
+                default: ''
+              }
             },
             annotations: {
               'require-adobe-auth': true,