Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load events and project as config #16

Merged
merged 10 commits into from Apr 18, 2023
Merged

Load events and project as config #16

merged 10 commits into from Apr 18, 2023

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Mar 30, 2023

Description

Adds a new key to app.config.yaml || ext.config.yaml to load event config
Adds the project from commonConfig under the project key for anyone who needs it.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage purplecabbage changed the title Load events Load events and project as config Mar 30, 2023
@purplecabbage purplecabbage marked this pull request as ready for review April 15, 2023 00:45
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #16 (33505fc) into master (41fefdc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          236       239    +3     
  Branches        64        65    +1     
=========================================
+ Hits           236       239    +3     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: Can some of the commented-out code in config-loader.js be deleted?

@purplecabbage
Copy link
Member Author

LGTM

nit: Can some of the commented-out code in config-loader.js be deleted?

this is a data-mock, which I expect to see expanded to include more varied projects.
commented portion is a workinprogress

@purplecabbage purplecabbage merged commit e07b921 into master Apr 18, 2023
7 checks passed
@purplecabbage purplecabbage deleted the LoadEvents branch April 18, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants