-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated package setup to use the latest mesh builder and install peer deps #97
Conversation
seems some peer dependencies has to be added to get the build success |
After Kris M's changes, the PR looks stable and working as expected. I have verified that the functionality is working as expected. Ready to merge. |
package.json
Outdated
}, | ||
"dependencies": { | ||
"@adobe-apimesh/mesh-builder": "1.3.2", | ||
"@adobe-apimesh/mesh-builder": "1.4.0-beta.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question regarding going to develop with beta version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was for testing, I published beta packages for testing. Once the PRs are approved, we can publish stable packages and update here.
package.json
Outdated
"version": "3.2.0", | ||
"publishConfig": { | ||
"access": "public" | ||
"version": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to update the version since we published 3.2.0 recently and I believe this PR was worked on before that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup yup, Ill update that to what we have in develop
. We can update the version before merging to main
.
to fix the string width error had to add resolution for jackspeak isaacs/jackspeak#5 (comment) |
Description
Using the latest mesh builder package and moving common deps to the CLI.
Related Issue
CEXT-2432
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: