Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated package setup to use the latest mesh builder and install peer deps #97

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

revanth0212
Copy link
Contributor

Description

Using the latest mesh builder package and moving common deps to the CLI.

Related Issue

CEXT-2432

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dani97
dani97 previously approved these changes Nov 3, 2023
@dani97
Copy link
Contributor

dani97 commented Nov 3, 2023

seems some peer dependencies has to be added to get the build success

@revanth0212
Copy link
Contributor Author

After Kris M's changes, the PR looks stable and working as expected. I have verified that the functionality is working as expected. Ready to merge.

package.json Outdated
},
"dependencies": {
"@adobe-apimesh/mesh-builder": "1.3.2",
"@adobe-apimesh/mesh-builder": "1.4.0-beta.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question regarding going to develop with beta version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for testing, I published beta packages for testing. Once the PRs are approved, we can publish stable packages and update here.

package.json Outdated Show resolved Hide resolved
package.json Outdated
"version": "3.2.0",
"publishConfig": {
"access": "public"
"version": "3.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to update the version since we published 3.2.0 recently and I believe this PR was worked on before that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup yup, Ill update that to what we have in develop. We can update the version before merging to main.

@dani97
Copy link
Contributor

dani97 commented Nov 21, 2023

to fix the string width error had to add resolution for jackspeak isaacs/jackspeak#5 (comment)

@dthampy dthampy merged commit dd21134 into develop Nov 28, 2023
2 checks passed
@amolina-adobe amolina-adobe deleted the revanth/peer-deps-update branch February 22, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants