Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle failures from pre-pack hook #727

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix: handle failures from pre-pack hook #727

merged 4 commits into from
Oct 16, 2023

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 8, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #727 (3f4c7e1) into master (814908d) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #727   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        56    -1     
  Lines         3229      3188   -41     
  Branches       607       599    -8     
=========================================
- Hits          3229      3188   -41     
Files Coverage Δ
src/commands/app/add/event.js 100.00% <100.00%> (ø)
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/pack.js 100.00% <100.00%> (ø)
src/commands/app/undeploy.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sangeetha5491 sangeetha5491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron changed the title Handle failures from pre-pack hook fix: handle failures from pre-pack hook Oct 16, 2023
@shazron shazron merged commit 3ade48d into master Oct 16, 2023
7 checks passed
@shazron shazron deleted the prepack-hook-error branch October 16, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants