Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin eslint-plugin-n to ^15.7 to support node 14 #730

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

MichaelGoberling
Copy link
Contributor

Description

Version ^16.0 of eslint-plugin-n doesn't support Node 14, but aio still does. Pin to ^15.7 for now

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MichaelGoberling
Copy link
Contributor Author

Tests are failing here during npm install trying to resolve the dependency tree. Once we get the shared eslint config PR merged and released, this should be fixed

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #730 (4eafa12) into master (c5b8b54) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #730   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3207      3207           
  Branches       605       605           
=========================================
  Hits          3207      3207           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit 448fe1f into master Sep 13, 2023
7 checks passed
@shazron shazron deleted the pin-eslint-plugin-n branch September 13, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants