fix: ACNA-2562 - artifacts and zip output should be in a .gitignored dist folder

[shazron]

These files have been moved:

1. app-package artifacts folder has been moved to dist/app-package
2. the default output app.zip has been moved to dist/app.zip.

This has been added:

1. all extension dist folders are excluded from the pack
2. the dist folder itself is excluded from the pack (just in case the .gitignore value is not there)
3. the dist/app-package folder will be deleted after the pack

How Has This Been Tested?

1. npm test
2. aio app pack on an App Builder project

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #736 (1a0f0cd) into master (bc39f62) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #736   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3223      3229    +6     
  Branches       607       607           
=========================================
+ Hits          3223      3229    +6     

Files	Coverage Δ
src/commands/app/pack.js	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shazron]

FYI @sangeetha5491 - slight change to the artifacts folder being passed in to the hook.

[MichaelGoberling]

Changes LGTM!

Follow up Q: Is there a known use case for being able to configure the output of the app zip? It seems useful, but I was wondering if we could maybe reduce the chance a dev accidentally packages foo/app.zip if the app zip always goes in dist/app.zip

[shazron]

Changes LGTM!

Follow up Q: Is there a known use case for being able to configure the output of the app zip? It seems useful, but I was wondering if we could maybe reduce the chance a dev accidentally packages foo/app.zip if the app zip always goes in dist/app.zip

The use case is if an ISV wants to automate and put all packages into a known folder, and they can name it immediately to what they want, say for archiving. Say --output ~/Desktop/my-app-packages/my-project-abc-2023-10-12.zip