Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not all missing files errors are because of an invalid root folder #755

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

MichaelGoberling
Copy link
Contributor

Description

Fixes #646

Related Issue

#646

Motivation and Context

How Has This Been Tested?

npm run test, locally linked plugin

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f35c49) 100.00% compared to head (ea02740) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #755   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3234      3227    -7     
  Branches       612       611    -1     
=========================================
- Hits          3234      3227    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling merged commit 2e4115c into master Dec 18, 2023
7 checks passed
@MichaelGoberling MichaelGoberling deleted the better-missing-files-errors branch December 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all missing files errors are because of not running in a valid root folder.
3 participants