Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inherit secrets for node.js CI workflow #791

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

MichaelGoberling
Copy link
Contributor

@MichaelGoberling MichaelGoberling commented Apr 17, 2024

Description

Note: Using this pr as a test bed for the branch that does not require the CODECOV_TOKEN to see if node ci still runs it works 🥳

Inherit secrets in the Node.JS CI workflow so we can upload coverage using the codecov@v4 action in the re-usable workflow.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4bf919) to head (79fd82d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #791   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3232      3241    +9     
  Branches       614       617    +3     
=========================================
+ Hits          3232      3241    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling merged commit 6566c29 into master Apr 19, 2024
8 checks passed
@MichaelGoberling MichaelGoberling deleted the node-ci-inherit-secrets branch April 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants