Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aio-lib-runtime major #91

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 29, 2022

Description

This uses the new bin script method of running your command.
Updated aio-lib-runtime version to support worker:runtime:nodejs:16
@oclif/config => (@oclif/core).Config
Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #91 (56a04e2) into master (f315b1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          13       13           
  Lines         857      857           
=======================================
  Hits          779      779           
  Misses         78       78           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jdelbick
Copy link
Contributor

jdelbick commented Oct 4, 2022

I will merge this on Friday or next week. I have a presentation for consultants for field enablement on Thursday and I want to wait to merge this until after since I won't have time to validate aio v9 works for Asset Compute Custom Workers.

@jdelbick
Copy link
Contributor

jdelbick commented Oct 7, 2022

i will merge as a bugfix release:
https://cq-dev.slack.com/archives/C013UDBFBGB/p1665161697013669?thread_ts=1664386796.277959&cid=C013UDBFBGB

Older versions should still target the previous version of the plugin.
With semver we should be okay.

@jdelbick jdelbick merged commit aa518c3 into adobe:master Oct 7, 2022
@adobe-bot
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants