Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use 'e'-prefixed env ids as found in cloud manager URLs #135

Conversation

ghenzler
Copy link

Description

just a convenience feature, in the cloud manager UI the environment ids show with an "e" prefix, allowing the e as prefix to be passed in would be nice

Motivation and Context

see description

How Has This Been Tested?

Tested it locally (used aio plugins:link)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #135 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   93.73%   93.76%   +0.03%     
==========================================
  Files          31       31              
  Lines        1021     1027       +6     
  Branches      119      120       +1     
==========================================
+ Hits          957      963       +6     
  Misses         58       58              
  Partials        6        6              
Impacted Files Coverage Δ
src/base-environment-variables-command.js 100.00% <100.00%> (ø)
src/cloudmanager-helpers.js 97.82% <100.00%> (+0.20%) ⬆️
src/commands/cloudmanager/delete-environment.js 100.00% <100.00%> (ø)
src/commands/cloudmanager/download-logs.js 96.42% <100.00%> (ø)
...ommands/cloudmanager/list-available-log-options.js 100.00% <100.00%> (ø)
...rc/commands/cloudmanager/open-developer-console.js 100.00% <100.00%> (ø)
...commands/cloudmanager/set-environment-variables.js 100.00% <100.00%> (ø)
src/commands/cloudmanager/tail-log.js 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a70476...a43a559. Read the comment docs.

@justinedelson
Copy link
Member

justinedelson commented Sep 29, 2020

Converted to an issue and submitting new PR rebased: #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants