Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support log downloads and tailing through CLI #37

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

justinedelson
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #37 into master will decrease coverage by 5.12%.
The diff coverage is 75.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   94.98%   89.86%   -5.13%     
==========================================
  Files          16       19       +3     
  Lines         479      651     +172     
  Branches       66       92      +26     
==========================================
+ Hits          455      585     +130     
- Misses         24       60      +36     
- Partials        0        6       +6
Impacted Files Coverage Δ
src/constants.js 100% <ø> (ø) ⬆️
src/client.js 79.28% <61.05%> (-11.17%) ⬇️
src/cloudmanager-helpers.js 97.05% <83.33%> (-2.95%) ⬇️
src/commands/cloudmanager/tail-logs.js 90.47% <90.47%> (ø)
...ommands/cloudmanager/list-available-log-options.js 95.65% <95.65%> (ø)
src/commands/cloudmanager/download-logs.js 96.42% <96.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a72b1c...8cc5741. Read the comment docs.

@justinedelson justinedelson mentioned this pull request Oct 10, 2019
@justinedelson justinedelson merged commit f209232 into master Oct 10, 2019
@justinedelson justinedelson added this to the 0.2.0 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants