Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check variable types before trying to delete. fixes #96 #97

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

justinedelson
Copy link
Member

Description

Deleting a secretString variable requires sending the type along with the deletion request. Failure to do so results in an error.

Fixing this also has the nice side-effect of not trying to delete variables that don't exist (thus saving some API calls).

Related Issue

#96

Motivation and Context

See bug report

How Has This Been Tested?

Updated tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #97 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   92.32%   92.39%   +0.07%     
==========================================
  Files          25       25              
  Lines         860      868       +8     
  Branches      104      106       +2     
==========================================
+ Hits          794      802       +8     
  Misses         60       60              
  Partials        6        6              
Impacted Files Coverage Δ
src/client.js 83.49% <100.00%> (ø)
...commands/cloudmanager/set-environment-variables.js 97.82% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cfb1c...f248f11. Read the comment docs.

@justinedelson justinedelson merged commit 4941272 into master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant