Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select org clears project+workspace, select project clears workspace,… #132

Merged
merged 1 commit into from May 15, 2020

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented May 15, 2020

… config key constants. Closes #128. Closes #119. Closes #120. Closes #121.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          299       296    -3     
  Branches        31        31           
=========================================
- Hits           299       296    -3     
Impacted Files Coverage Δ
src/commands/console/index.js 100.00% <100.00%> (ø)
src/commands/console/org/select.js 100.00% <100.00%> (ø)
src/commands/console/project/select.js 100.00% <100.00%> (ø)
src/commands/console/workspace/download.js 100.00% <100.00%> (ø)
src/commands/console/workspace/list.js 100.00% <100.00%> (ø)
src/commands/console/workspace/select.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30de888...1bcac91. Read the comment docs.

@purplecabbage purplecabbage mentioned this pull request May 15, 2020
4 tasks
@shazron shazron merged commit d262738 into adobe:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants