Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use actual versions and semver.satisfies #40

Merged
merged 6 commits into from
Aug 14, 2023
Merged

feat: use actual versions and semver.satisfies #40

merged 6 commits into from
Aug 14, 2023

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 15, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage
Copy link
Member Author

needs test

@purplecabbage purplecabbage marked this pull request as ready for review January 11, 2023 01:48
@shazron shazron changed the title use actual versions and semver.satisfies feat: use actual versions and semver.satisfies Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #40 (8473d44) into master (d734bfc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           90        91    +1     
  Branches        19        19           
=========================================
+ Hits            90        91    +1     
Files Changed Coverage Δ
src/commands/info.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tests

@shazron shazron merged commit c922cc0 into master Aug 14, 2023
7 checks passed
@shazron shazron deleted the UseSemver branch August 14, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants