Skip to content

Commit

Permalink
fix: pin swagger-client to 3.9.6 (#15)
Browse files Browse the repository at this point in the history
The 3.10.x versions break our API during runtime when using swagger-client. We will eventually have to fix these issues.

* fix: linting issues
* fix: lint e2e folder
  • Loading branch information
shazron committed May 13, 2020
1 parent 863ca4c commit 3bf3da9
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
7 changes: 6 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
{
"extends": ["@adobe/eslint-config-aio-lib-config"]
"extends": ["@adobe/eslint-config-aio-lib-config"],
"settings": {
"jsdoc": {
"ignorePrivate": true
}
}
}
5 changes: 5 additions & 0 deletions e2e/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"rules": {
"node/no-unpublished-require": 0
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@adobe/aio-lib-core-errors": "^3.0.0",
"@adobe/aio-lib-core-logging": "1.1.0",
"change-case": "^4.1.1",
"swagger-client": "^3.9.0",
"swagger-client": "3.9.6",
"uuid": "^8.0.0"
},
"deprecated": false,
Expand Down Expand Up @@ -49,7 +49,7 @@
"e2e": "jest --config e2e/jest.config.js",
"generate-docs": "npm run generate-methods4docs && npm run typings && npm run jsdoc",
"jsdoc": "jsdoc2md -t ./docs/readme_template.md src/**/*.js > README.md",
"lint": "eslint src test",
"lint": "eslint src test e2e",
"test": "npm run validate && npm run lint && npm run unit-tests",
"typings": "jsdoc -t node_modules/tsd-jsdoc/dist -r src/*.js -d .",
"unit-tests": "jest --config test/jest.config.js --maxWorkers=2",
Expand Down
4 changes: 0 additions & 4 deletions src/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ governing permissions and limitations under the License.
const loggerNamespace = '@adobe/aio-lib-customer-profile'
const logger = require('@adobe/aio-lib-core-logging')(loggerNamespace, { level: process.env.LOG_LEVEL })

/* global Request, Response */ // for linter

/**
* Reduce an Error to a string
*
Expand All @@ -36,8 +34,6 @@ function reduceError (error = {}) {
* Create request options for openapi client
*
* @private
* @param {object} parameters object
* @returns {object} options request options
*/
function createRequestOptions ({ tenantId, apiKey, accessToken, body = {} }) {
return {
Expand Down

0 comments on commit 3bf3da9

Please sign in to comment.