Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vscode autocompletion #22

Merged
merged 2 commits into from
Jul 24, 2020
Merged

fix vscode autocompletion #22

merged 2 commits into from
Jul 24, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Jul 22, 2020

Description

fix for #5

similar to
adobe/aio-lib-files#50
adobe/aio-lib-state#53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          112       111    -1     
  Branches        15        15           
=========================================
- Hits           112       111    -1     
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b282129...79fd0e1. Read the comment docs.

@moritzraho
Copy link
Member Author

moritzraho commented Jul 22, 2020

@easingthemes I have removed the methods4docs.js files and tools, could you check if autocompletion still works with webstorm 🙏
EDIT: nvm seems that this removes the api content in the readme actually, reverting my last change

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it by npm packing this and installing in a new module (npm init -y) and requiring it, and trying to access autocomplete for the generated methods. I could find them in autocomplete.

@moritzraho moritzraho merged commit 896fe19 into adobe:master Jul 24, 2020
@moritzraho moritzraho deleted the fix-docs branch July 24, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants