Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general swagger/openApi SDK #3

Merged
merged 26 commits into from
Mar 2, 2020
Merged

Conversation

easingthemes
Copy link
Collaborator

Description

  1. openApi SDK: creating dynamic methods based on openApi spec file
  2. CustomerProfile SDK: extending openApi SDK and adding custom methods
  3. Tools added for fetching latest API spec and converting from swagger to openApi

Related Issue

Initial SDK

Motivation and Context

Initial SDK

How Has This Been Tested?

Tested in active project

Screenshots (if appropriate):

Types of changes

Initial SDK v1.0.0

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. *
  • All new and existing tests passed. *

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines          63    112   +49     
  Branches        7     15    +8     
=====================================
+ Hits           63    112   +49
Impacted Files Coverage Δ
src/helpers.js 100% <ø> (ø) ⬆️
src/openApiSDK.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️
src/SDKErrors.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c4504...21f0114. Read the comment docs.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge contribution! Just some minor changes requested.

e2e/README.md Outdated Show resolved Hide resolved
src/SDKErrors.js Show resolved Hide resolved
e2e/e2e.js Outdated Show resolved Hide resolved
e2e/e2e.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
types.d.ts Outdated Show resolved Hide resolved
tools/apiDocs.js Outdated Show resolved Hide resolved
@shazron shazron merged commit 443f9a9 into adobe:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants