Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GET calls fail with swagger client because of empty body in calls #30

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

sandeep-paliwal
Copy link
Contributor

Fixes #29
Fixed issue with latest swagger client throwing error for empty body for get calls.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing because of linter issue

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #30 (463ee97) into master (9e5562c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          133       135    +2     
  Branches        25        26    +1     
=========================================
+ Hits           133       135    +2     
Impacted Files Coverage Δ
src/openApiSDK.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1ae3d...463ee97. Read the comment docs.

@shazron shazron changed the title Fix swagger client error fix: GET calls fail with swagger client because of empty body in calls Jun 29, 2021
@shazron shazron merged commit 12749f9 into master Jun 29, 2021
@shazron shazron deleted the fix_swagger_client_issue branch June 29, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET calls fail with swagger client because of empty body in calls
2 participants