Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: badges and docs #4

Merged
merged 2 commits into from May 12, 2020
Merged

fix: badges and docs #4

merged 2 commits into from May 12, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented May 12, 2020

Description

README should not be touched, only edit docs/readme_template.md and the source code jsdoc, then run npm run generate-docs.
Fixed linting warnings.

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          248       248           
  Branches        33        33           
=========================================
  Hits           248       248           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/journalling.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0534408...d870664. Read the comment docs.

@shazron shazron merged commit 529c02e into master May 12, 2020
@shazron shazron deleted the badges branch May 12, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants