Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update on setCurrent context #61

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Feb 17, 2021

Description

Update README to give more information on risks related to setCurrent context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho changed the title Doc update on setContext Doc update on setCurrent context Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #61 (398a21d) into master (9f90afc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          388       388           
  Branches        47        47           
=========================================
  Hits           388       388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d97ae...398a21d. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@moritzraho
Copy link
Member Author

@shazron can we merge this ?

@shazron shazron merged commit 97b1bff into master Mar 1, 2021
@shazron shazron deleted the readme-context-modification branch March 1, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants