refactoring registration and provider service to make it resilient for conflict errors #200
Conversation
…m get provider call
|
@francoisledroff : please approve |
| return updateProvider(providerId,providerInputModel); | ||
| } catch (ConflictException e){ | ||
| String conflictingProviderId = e.getConflictingId(); | ||
| logger.warn("Another provider (id: `{}` ) exist with conflict due to {}, trying to update it ...", |
There was a problem hiding this comment.
logger.info would be enough, don't you think ?
| return createRegistration(registrationCreateModelBuilder); | ||
| } catch (ConflictException ex) { | ||
| String conflictingRegistrationId = ex.getConflictingId(); | ||
| logger.warn("Another registration (id `{}`) exists with conflict due to {}. Trying to update it...", conflictingRegistrationId, ex.getMessage()); |
There was a problem hiding this comment.
logger.info would be enough, don't you think ?
| @@ -51,7 +51,7 @@ public void createGetDeleteJournalRegistration() { | |||
| try { | |||
| providerId = providerServiceTester.createOrUpdateProvider(TEST_EVENT_PROVIDER_LABEL, | |||
| TEST_EVENT_CODE).getId(); | |||
| Registration registration = createJournalRegistration(TEST_REGISTRATION_NAME, providerId, | |||
| Registration registration = createOrUpdateJournalRegistration(TEST_REGISTRATION_NAME, providerId, | |||
There was a problem hiding this comment.
may be we could test both path ?
using createOrUpdate once and then createOrUpdate again ... once created
here and may be in ProviderServiceIntegrationTest too
wdyt ?
…d update flows without any conflict eexception
|
@francoisledroff : how can we retrigger the integration test? Locally it is getting passed. |
| () -> registrationService.findById(finalRegistrationId)); | ||
|
|
||
| // covering the update path | ||
| registration = createOrUpdateJournalRegistration(TEST_REGISTRATION_NAME, providerId, |
There was a problem hiding this comment.
could you add the same coverage for the ProviderService pretty please ?
There was a problem hiding this comment.
Well,I have done this here in the ProviderServiceIntegrationTest, is there any other place I need to do that you meant?
There was a problem hiding this comment.
oh I did not catch this, thanks !
| String updatedProviderDescription = "updated Provider Description"; | ||
| Optional<Provider> updatedProvider = providerService.updateProvider(providerId, | ||
| getTestProviderInputModelBuilder(TEST_EVENT_PROVIDER_LABEL) | ||
| Provider updatedProvider = createOrUpdateProvider(getTestProviderInputModelBuilder(TEST_EVENT_PROVIDER_LABEL) |
abhupadh
changed the title
Description
See issue description
Related Issue
#199
https://jira.corp.adobe.com/browse/CI-6365
Motivation and Context
Make our e2e more resilient
How Has This Been Tested?
Using
aio-events-itestsrunning locallyScreenshots (if appropriate):
Types of changes
Checklist: