Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate key characters, throw actionable error #87

Merged
merged 1 commit into from Nov 14, 2022

Conversation

MichaelGoberling
Copy link
Contributor

Description

  • Validate keys against regex, disallow ?, #, /, \
  • Throw actionable error

Related Issue

Closes #86

How Has This Been Tested?

Locally linked aio-lib-state in action, npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #87 (ba1ea80) into master (3b6d45f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          167       167           
  Branches        33        33           
=========================================
  Hits           167       167           
Impacted Files Coverage Δ
lib/StateStoreError.js 100.00% <ø> (ø)
lib/StateStore.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@MichaelGoberling MichaelGoberling merged commit 92bee86 into master Nov 14, 2022
@MichaelGoberling MichaelGoberling deleted the fix/validate-key-characters branch November 14, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws firewall error when using invalid characters for keys
2 participants