Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-508/509/343 deploy using runtime helper, remove aio runtime dep #24

Merged
merged 9 commits into from
Nov 5, 2019

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Oct 29, 2019

Description

This PR modifies deploy and undeploy to use aio runtime helpers (as api) instead of aio runtime cli plugin (from command line). This comes with the following advantages:

  • syncs projects properly with what is already deployed, cleans up zombie actions (using aio runtime's sync)
  • deletes additional actions in deployment packages ( solves Actions generated by wskdebug don't get removed upon undeploy #19 )
  • more control on deployment and undeployment process, e.g. real time progress messages
  • no need of installing aio-cli-plugin-runtime globally
  • faster
  • does not generate a .dist-manifest.yml anymore
  • opens up some opportunities for more flexible and unified config logic (i.e. not mandatory to name env vars after runtime plugin like AIO_RUNTIME_* anymore)

DO NOT MERGE YET DEPENDS ON adobe/aio-cli-plugin-runtime#61

Screenshot

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho changed the title [WIP] deploy using runtime helper, remove aio runtime dep ACNA-508/509/343 deploy using runtime helper, remove aio runtime dep Nov 4, 2019
lib/utils.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants